Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-normative issues #195

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix non-normative issues #195

wants to merge 2 commits into from

Conversation

FragLegs
Copy link
Contributor

@FragLegs FragLegs requested a review from a team as a code owner August 12, 2024 17:25
tulshi
tulshi reviewed Aug 12, 2024
View reviewed changes
openid-sharedsignals-framework-1_0.md
@@ -951,6 +953,7 @@ Configuration ({{stream-config}}) object:
* `events_requested`
* `delivery` : Note that in the case of the poll method, the `endpoint_url` value is
supplied by the Transmitter.
* `description`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks strange. Should there be an explanation after this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not have an explanation, but I can move the note that is attached to delivery so that it is below the list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is a normative change. Any reason to think of this as a non-normative change?

@timcappalli
Copy link
Member

This PR should split out normative and non-normative changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulshi tulshi tulshi left review comments

@timcappalli timcappalli timcappalli approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FragLegs @timcappalli @tulshi